-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Workload Management] QueryGroup Stats API Logic #15777
base: main
Are you sure you want to change the base?
Conversation
88c9cff
to
b66823c
Compare
❌ Gradle check result for f647487: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
b66823c
to
9c241b7
Compare
❌ Gradle check result for 88c9cff: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
❌ Gradle check result for b66823c: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
Signed-off-by: Ruirui Zhang <[email protected]>
Signed-off-by: Ruirui Zhang <[email protected]>
Signed-off-by: Ruirui Zhang <[email protected]>
Signed-off-by: Ruirui Zhang <[email protected]>
Signed-off-by: Ruirui Zhang <[email protected]>
Signed-off-by: Ruirui Zhang <[email protected]>
Signed-off-by: Ruirui Zhang <[email protected]>
Signed-off-by: Ruirui Zhang <[email protected]>
Signed-off-by: Ruirui Zhang <[email protected]>
Signed-off-by: Ruirui Zhang <[email protected]>
Signed-off-by: Ruirui Zhang <[email protected]>
Signed-off-by: Ruirui Zhang <[email protected]>
Signed-off-by: Ruirui Zhang <[email protected]>
Signed-off-by: Ruirui Zhang <[email protected]>
Signed-off-by: Ruirui Zhang <[email protected]>
Signed-off-by: Ruirui Zhang <[email protected]>
Signed-off-by: Ruirui Zhang <[email protected]>
Signed-off-by: Ruirui Zhang <[email protected]>
Signed-off-by: Ruirui Zhang <[email protected]>
9f49a74
to
d1d7441
Compare
❌ Gradle check result for d1d7441: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
@ruai0511 - Precommit is failing, can you address that? |
d1d7441
to
f8e6ac4
Compare
final SearchRequestOperationsCompositeListenerFactory searchRequestOperationsCompositeListenerFactory = | ||
new SearchRequestOperationsCompositeListenerFactory( | ||
Stream.concat( | ||
Stream.of( | ||
searchRequestStats, | ||
searchRequestSlowLog, | ||
searchTaskRequestOperationsListener, | ||
queryGroupRequestOperationListener | ||
), | ||
pluginComponents.stream() | ||
.filter(p -> p instanceof SearchRequestOperationsListener) | ||
.map(p -> (SearchRequestOperationsListener) p) | ||
).toArray(SearchRequestOperationsListener[]::new) | ||
); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We don't need TransportService
into QueryGroupService
. The nodeStats
within QueryGroupService
should be completely oblivious of the localNodeId
. It should just return the new QueryGroupStats(statsHolderMap)
. TransportAction can create the WlmStats
object from QueryGroupStats
.
❌ Gradle check result for f8e6ac4: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
Signed-off-by: Ruirui Zhang <[email protected]>
f8e6ac4
to
7dcd545
Compare
❌ Gradle check result for 7dcd545: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
Description
This change introduces the QueryGroup Stats API as part of this RFC: #12342.
The QueryGroup Stats API schema is:
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.